Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden columns are scaffolded for Azure databases #14566

Closed
Manny651 opened this issue Jan 31, 2019 · 1 comment · Fixed by #15438
Closed

Hidden columns are scaffolded for Azure databases #14566

Manny651 opened this issue Jan 31, 2019 · 1 comment · Fixed by #15438
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
3.0.0

Comments

@Manny651
Copy link

Same problem as #8192, but for Azure SQL Databases. When scaffolding an Azure SQL Databases to EF Core, Hidden Columns are not excluded. As a result, columns used for SQL Temporal Tables get scaffolded back into the application.

From what I can see in the current implementation, the Temporal Tables feature detection is based on the server version (13 / SQL Server 2016). This is a problem for Azure databases, which run on an engine based on SQL Server 2014, but have can have an higher compatibility level (i.e. SQL Server 2017).

Steps to reproduce

Add Temporal System Versioning on an Azure database, then run Scaffold-DbContext from that database.
@bricelam
Copy link
Contributor

bricelam commented Feb 1, 2019

We talked about using compatibility level in #5553

@ajcvickers ajcvickers added this to the 3.0.0 milestone Feb 1, 2019
ErikEJ added a commit to ErikEJ/EntityFramework that referenced this issue Apr 22, 2019
@ErikEJ
SQL Server scaffolding:
71c047b 
Use compatibility_level for feature detection
Unblock scaffolding on Azure SQL DW

fixes dotnet#14566
fixes dotnet#5553
@ErikEJ ErikEJ mentioned this issue Apr 22, 2019
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 22, 2019
bricelam pushed a commit that referenced this issue Apr 22, 2019
@ErikEJ @bricelam
SQL Server scaffolding:
869a117 
Use compatibility_level for feature detection
Unblock scaffolding on Azure SQL DW

fixes #14566
fixes #5553
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview5 Apr 22, 2019
@ajcvickers ajcvickers mentioned this issue Apr 25, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview5, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

SQL Server scaffolding fixes ErikEJ/EntityFramework
3 participants
@bricelam @ajcvickers @Manny651