Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all Jetbrains nullability annotations #14568

Closed
roji opened this issue Jan 31, 2019 · 2 comments · Fixed by #24418
Closed

Remove all Jetbrains nullability annotations #14568

roji opened this issue Jan 31, 2019 · 2 comments · Fixed by #24418
Assignees
@roji
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Jan 31, 2019 •
edited
Loading

At some point in the future, once C# 8 has gained enough traction (and/or newer versions of R#/Rider start recognizing C# 8 nullability attributes), we can remove [CanBeNull] and [NotNull] attributes from our codebase.

Part of #19007
@ajcvickers ajcvickers added this to the Backlog milestone Feb 1, 2019
@ajcvickers ajcvickers added closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. and removed blocked consider-for-current-release labels Nov 20, 2019
@ajcvickers ajcvickers removed this from the Backlog milestone Nov 20, 2019
@roji roji mentioned this issue Feb 3, 2020
Closed
@roji roji reopened this Mar 16, 2021
@roji
Copy link
Member Author

roji commented Mar 16, 2021

(Modern) Jetbrains IDEs recognize the C# NRT annotations in the same way as they recognize the Jetbrains attributes. Since EF Core will target at least net5.0 (or more likely, net6.0), a modern VS/R#/Rider is needed in any case, so there doesn't seem to be any value in keeping the Jetbrains attributes.

@roji
Copy link
Member Author

roji commented Mar 16, 2021

A bit more info from Jetbrains with confirmation that R#/Rider recognize the Roslyn nullability information in the same way as the JB attributes: https://blog.jetbrains.com/dotnet/2020/05/26/nullable-contexts-nullable-attributes/

@roji roji added area-global and removed closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. labels Mar 16, 2021
@roji roji self-assigned this Mar 16, 2021
@roji roji added this to the 6.0.0 milestone Mar 16, 2021
@roji roji mentioned this issue Mar 17, 2021
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 17, 2021
@roji roji closed this as completed Mar 17, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview3 Mar 25, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview3, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove Jetbrains nullability attributes dotnet/efcore
2 participants
@ajcvickers @roji