Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate EF Core for nullable reference types #19007

Closed
23 tasks done
Tracked by #43619
roji opened this issue Nov 21, 2019 · 12 comments · Fixed by #23133, #23126, #23147, #23938 or #23905
Closed
23 tasks done
Tracked by #43619

Annotate EF Core for nullable reference types #19007

roji opened this issue Nov 21, 2019 · 12 comments · Fixed by #23133, #23126, #23147, #23938 or #23905
Assignees
@bricelam @smitpatel @roji
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement User Story A single user-facing feature. Can be grouped under an epic.
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Nov 21, 2019 •
edited
Loading

Note: #14150 tracks introducing nullability to non-public parts as well (i.e. annotate the entire codebase), and isn't currently planned for 5.0.

This issue now tracks annotating the entire codebase for C# 8 NRTs.

/cc @rynowak @cartermp

Work status

  • Analyzers
  • Abstractions
  • Change tracking (@smitpatel)
  • Design (@bricelam)
  • Diagnostics
  • Extensions
  • Infrastructure
  • Internal
  • Metadata
  • Microsoft.Data.Sqlite
  • Migrations (@bricelam)
  • Proxies
  • Query (leftovers in Cosmos, @smitpatel)
  • Storage (leftovers in Cosmos, @roji)
  • Tools & cmdline (@bricelam)
  • Update (@roji)
  • ValueGeneration (@roji)

Some specific leftovers we need to do:
@roji roji added this to the 5.0.0 milestone Nov 21, 2019
@roji roji self-assigned this Nov 21, 2019
@roji roji mentioned this issue Jan 3, 2020
Closed
@ajcvickers
Copy link
Member

Consider specifically the scenario in #19443 when working on this.

@roji roji mentioned this issue Feb 3, 2020
Closed
@ajcvickers ajcvickers removed this from the 5.0.0 milestone Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Mar 16, 2020
@ajcvickers
Copy link
Member

Tag: C# nullable reference types

@ajcvickers ajcvickers mentioned this issue Apr 2, 2020
Closed
@roji roji mentioned this issue Jul 26, 2020
Closed
@roji
Copy link
Member Author

roji commented Jul 31, 2020

Note: for LINQ async operators (e.g. FirstOrDefaultAsync): dotnet/roslyn#45993 (but depends on C# 9)

@smitpatel smitpatel mentioned this issue Oct 28, 2020
Merged
roji added a commit that referenced this issue Oct 30, 2020
@roji
Nullable annotations for metadata 2
66afa93 
Annotates Model, Property, Navigation, Key, Index, and all their extensions.

Part of #19007
@roji roji mentioned this issue Oct 30, 2020
Merged
This was linked to pull requests Oct 30, 2020
First nullability work on metadata #23133
Merged
Annotate query with nullable reference types #23126
Merged
Nullable annotations for metadata 2 #23147
Merged
roji added a commit that referenced this issue Oct 31, 2020
@roji
Nullable annotations for metadata 2
216b034 
Annotates Model, Property, Navigation, Key, Index, and all their extensions.

Part of #19007
roji added a commit that referenced this issue Oct 31, 2020
@roji
Nullable annotations for metadata 2
71f418c 
Annotates Model, Property, Navigation, Key, Index, and all their extensions.

Part of #19007
@ghost ghost closed this as completed in #23147 Oct 31, 2020
ghost pushed a commit that referenced this issue Oct 31, 2020
@roji
Nullable annotations for metadata 2 (#23147)
319db8b 
Annotates Model, Property, Navigation, Key, Index, and all their extensions.

Part of #19007
@smitpatel smitpatel reopened this Oct 31, 2020
@smitpatel
Copy link
Contributor

This is done?

bricelam added a commit to bricelam/efcore that referenced this issue Mar 9, 2021
@bricelam
Design: Annotate NRTs
a4195e6 
Part of dotnet#19007
bricelam added a commit to bricelam/efcore that referenced this issue Mar 9, 2021
@bricelam
Design: Annotate NRTs
87cdf83 
Part of dotnet#19007
@smitpatel smitpatel removed their assignment Mar 10, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Mar 12, 2021
@bricelam
Design: Annotate NRTs
6b67f44 
Part of dotnet#19007
@bricelam bricelam mentioned this issue Mar 12, 2021
Merged
bricelam added a commit to bricelam/efcore that referenced this issue Mar 12, 2021
@bricelam
Design: Annotate NRTs
050dad6 
Part of dotnet#19007
@davidkarlsson davidkarlsson mentioned this issue Mar 15, 2021
Open
bricelam added a commit to bricelam/efcore that referenced this issue Mar 15, 2021
@bricelam
Design: Annotate NRTs
1a454bf 
Fixes dotnet#24403, part of dotnet#19007
ghost pushed a commit that referenced this issue Mar 15, 2021
@bricelam
Design: Annotate NRTs (#24388)
3d6009b 
Fixes #24403, part of #19007
roji added a commit that referenced this issue Mar 15, 2021
@roji
Activate nullability for all product code
3ce0de1 
* Enable nullability warnings as errors
* Remove all individual file #nullable enable

Part of #19007
@roji roji mentioned this issue Mar 15, 2021
Merged
@bricelam bricelam removed their assignment Mar 15, 2021
ghost pushed a commit that referenced this issue Mar 15, 2021
@roji
Activate nullability for all product code (#24406)
847bf3d 
* Enable nullability warnings as errors
* Remove all individual file #nullable enable

Part of #19007
@davidkarlsson
Copy link

Not sure if this has been fixed already but I've ran across a rather strange error that might be easy to miss which I think is related to the ef core analyzer and nullability which causes CS8619 warnings. I reported the issue in the Roslyn repo (dotnet/roslyn#51886) because I didn't see that it was related to EF Core at first.

Basically if you create an anonymous type from a type that has nullable ref types with a lambda expression and you then also call an async ef method in a loop like FirstOrDefaultAsync() or SaveChangesAsync() in the same method you will get a CS8619 warning saying that the anonymous type doesn't match the expected type.

The same problem happens in both 5.0.4 and 6.0.0-preview.2.21154.2.

This was referenced Mar 16, 2021
Closed
Closed
Open
@roji
Copy link
Member Author

roji commented Mar 17, 2021

Split off annotating tests to #24427

@roji roji closed this as completed Mar 18, 2021
@roji roji assigned bricelam and smitpatel and unassigned maumar Mar 18, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview3 Mar 25, 2021
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 28, 2021
@roji roji mentioned this issue May 20, 2021
Closed
@roji roji mentioned this issue Oct 28, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview3, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

@smitpatel smitpatel

@roji roji

Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Milestone
6.0.0
7 participants
@Socolin @bricelam @ajcvickers @smitpatel @maumar @davidkarlsson @roji