Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story: Developers using C# nullable reference types can use them with more Microsoft SDKs to validate correctness of their code #43619

Closed
4 of 5 tasks
cathysull opened this issue Oct 19, 2020 · 6 comments
Assignees
Labels
area-Meta Priority:1 Work that is critical for the release, but we could probably ship without Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@cathysull
Copy link
Member

cathysull commented Oct 19, 2020

In .NET 5, 94% of Microsoft.NetCore.App has been completed, which is the lowest layer in the shared framework and represents the set of APIs that are referenced by default by all applications types. We’ll work to get this number to 100% and we intend to maintain 100% coverage into the future.

What’s still missing are the higher layers (WPF, WinForms, ASP.NET Core) as well as the out-of-band packages (such as EFCore and several out-of-band packages from dotnet/runtime, as well as assemblies that aren't in netcoreapp but are included with aspnetcoreapp). While each is likely to be too big to be completed in .NET 6, we will start planning and making inroads for the rest of the stack and decide if we are comfortable introducing new libraries which may have no nullable annotations (e.g. mobile SDKs/Forms for .NET 6). An MVP (minimum viable product) for this, we believe (and will test) that any new libraries are annotated, moving forward nullable reference types are just part of the language, and when you decide the data type of some method parameter or return value, it's just one of the things you need to factor in, just as we need to factor in new types added in the libraries, new language features around optional parameters or params arguments and such things.

Work Items

@cathysull cathysull added the User Story A single user-facing feature. Can be grouped under an epic. label Oct 19, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Meta untriaged New issue has not been triaged by the area owner labels Oct 19, 2020
@safern
Copy link
Member

safern commented Oct 19, 2020

Related to: #41720

@terrajobst
Copy link
Member

@safern thanks! I've linked from the user story.

@cathysull cathysull added the Priority:1 Work that is critical for the release, but we could probably ship without label Oct 30, 2020
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Nov 27, 2020
@marek-safar marek-safar changed the title User Story: Complete Nullable annotations for more of the framework User Story: Developers using C# nullable reference types can use them with more Microsoft SDKs to validate correctness of their code Nov 27, 2020
@joperezr joperezr added this to the 6.0.0 milestone Feb 9, 2021
@danmoseley
Copy link
Member

@cathysull @terrajobst @jeffhandley is there any more here for 6.0? I assume not - we made progress, but none of these were "completed" (which is OK) so we should change the milestone to 7.0

@jeffhandley
Copy link
Member

Agreed. We did hit 100% annotated across netcoreapp, which was the firm commitment we made from the libraries team; the rest can carry over to 7.0.0.

@jeffhandley jeffhandley modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@jeffhandley jeffhandley modified the milestones: 7.0.0, 8.0.0 Aug 11, 2022
@jeffhandley jeffhandley added this to the Future milestone Aug 11, 2022
@mairaw
Copy link
Contributor

mairaw commented May 26, 2023

I'm cleaning up the .NET 6 project. This shows as completed on the project dashboard but still open here. Should any remaining work be on a new issue attached to a new milestone?

@jeffhandley
Copy link
Member

I'm leaving #41720 open and will get that updated with the remaining efforts, but I'm closing this User Story since the rest of the work was completed already.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta Priority:1 Work that is critical for the release, but we could probably ship without Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Projects
No open projects
Development

No branches or pull requests

9 participants