Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated may be null #19778

Closed
wants to merge 6 commits into from
Closed

Updated may be null #19778

wants to merge 6 commits into from

Conversation

Pentadome
Copy link

No description provided.

See summary above these properties
See summary above this property
PropertyInfo and FieldInfo may be null.
See summaries above these properties
@dnfclas
Copy link

dnfclas commented Feb 3, 2020

CLA assistant check
All CLA requirements met.

@roji
Copy link
Member

roji commented Feb 3, 2020

@wrkettlitz it seems like you're adding C# 8.0 nullability annotations to some reference types; this doesn't have an effect without also enabling nullability (via #nullable enable in the source file or <Nullable>enable</Nullable> in the csproj); in fact, putting these without enabling nullability will generate warnings (as errors).

Annotating public APIs for nullability is tracked #19007, and is a huge task that is better done bottom-up, and with good knowledge of the internals. Are you intending to progressively annotate other parts of EF Core, or is this a one-off proposal? Any reason you're looking to annotate these APIs specifically?

@Pentadome Pentadome closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants