Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServer/SqliteServiceCollectionExtensions are in different folder structure #14842

Closed
smitpatel opened this issue Feb 26, 2019 · 1 comment · Fixed by #16005
Closed

SqlServer/SqliteServiceCollectionExtensions are in different folder structure #14842

smitpatel opened this issue Feb 26, 2019 · 1 comment · Fixed by #16005
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

SqlServer puts it under Extensions.
SQLite puts it under Infrastructure.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 1, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog May 10, 2019
@AndriySvyryd
Copy link
Member

Also move extensions for our types to the folder corresponding to the namespace.

@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 3.0.0 Jun 8, 2019
AndriySvyryd added a commit that referenced this issue Jun 8, 2019
@AndriySvyryd
Move extensions classes to consistent locations
4f9c0da 
Fixes #14842
@AndriySvyryd AndriySvyryd mentioned this issue Jun 8, 2019
Merged
AndriySvyryd added a commit that referenced this issue Jun 10, 2019
@AndriySvyryd
Move extensions classes to consistent locations
f58fcce 
Fixes #14842
AndriySvyryd added a commit that referenced this issue Jun 10, 2019
@AndriySvyryd
Move extensions classes to consistent locations
b62c28f 
Fixes #14842
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 10, 2019
@AndriySvyryd AndriySvyryd removed their assignment Jun 10, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Move extensions classes to consistent locations dotnet/efcore
5 participants
@bricelam @ajcvickers @smitpatel @roji @AndriySvyryd