Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryRewrite: clean up query validation for various negative cases #15312

Closed
maumar opened this issue Apr 10, 2019 · 3 comments · Fixed by #21344
Closed

QueryRewrite: clean up query validation for various negative cases #15312

maumar opened this issue Apr 10, 2019 · 3 comments · Fixed by #21344
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Apr 10, 2019

We have a number of tests that verify we validate negative inputs correctly. Those are now different in many places. Disabling tests for now and will clean them up once we have a fuller picture of the entire pipeline.
@maumar maumar self-assigned this Apr 10, 2019
@maumar maumar added this to the 3.0.0 milestone Apr 10, 2019
@maumar
Copy link
Contributor Author

maumar commented Apr 10, 2019

disabled tests:

From_sql_queryable_stored_procedure_with_include_throws
Throws_when_select_many
FirstOrDefault_without_orderby_and_filter_issues_warning_subquery
Comparing_collection_navigation_to_null_issues_possible_unintended_consequences_warning
Comparing_two_collections_together_issues_possible_unintended_reference_comparison_warning
From_sql_queryable_stored_procedure_with_include_throws
Include_property_expression_invalid
Include_bad_navigation_property
Include_bad_navigation_property_simple
Include_specified_on_non_entity_not_supported
Then_include_property_expression_invalid

@smitpatel
Copy link
Contributor

I am adding few more.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@smitpatel
Copy link
Contributor

@maumar - I think you have fixed most of these (added validations in source code). It would be good to just scrub here if we are missing anything still so we can prioritize properly (or just add them if it is easy).

@smitpatel smitpatel assigned smitpatel and unassigned maumar Jun 19, 2020
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Jun 19, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 19, 2020
smitpatel added a commit that referenced this issue Jun 19, 2020
@smitpatel
Query: Clean up query validation for various negative cases
661189b 
Resolves #15312
@smitpatel smitpatel mentioned this issue Jun 19, 2020
Merged
smitpatel added a commit that referenced this issue Jun 19, 2020
@smitpatel
Query: Clean up query validation for various negative cases
7163098 
Resolves #15312
smitpatel added a commit that referenced this issue Jun 20, 2020
@smitpatel
Query: Clean up query validation for various negative cases (#21344)
973af84 
Resolves #15312
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Clean up query validation for various negative cases dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar