Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryRewite/Test: improve AssertIncludeQuery to properly handle partial include matches #15368

Closed
maumar opened this issue Apr 15, 2019 · 0 comments · Fixed by #20958
Closed

QueryRewite/Test: improve AssertIncludeQuery to properly handle partial include matches #15368

maumar opened this issue Apr 15, 2019 · 0 comments · Fixed by #20958
Assignees
@smitpatel
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Apr 15, 2019

With the new design we allow partial include matches, e.g.

entities.Include(e => e.Reference1.Reference2).Select(e => e.Reference1)

Our current test infra doesn't handle them correctly, we assume that entities present in the final projection either have all the includes or none of them.

Perhaps client projections argument to the AssertIncludeQuery should take starting navigation path to the entity it indicates, so the comparing logic knows which includes are expected.
@maumar maumar self-assigned this Apr 15, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 3, 2019
@smitpatel smitpatel mentioned this issue Jun 5, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@smitpatel smitpatel assigned smitpatel and unassigned maumar May 14, 2020
smitpatel added a commit that referenced this issue May 14, 2020
@smitpatel
Tests : A better infrastructure for asserting includes in the query
d8e09b6 
Remove AssertIncludeQuery which is based on queryable
Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter

Resolves #15368
@smitpatel smitpatel mentioned this issue May 14, 2020
Merged
smitpatel added a commit that referenced this issue May 14, 2020
@smitpatel
Tests : A better infrastructure for asserting includes in the query
d1222ea 
Remove AssertIncludeQuery which is based on queryable
Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter

Resolves #15368
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 14, 2020
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 May 14, 2020
smitpatel added a commit that referenced this issue May 14, 2020
@smitpatel
Tests : A better infrastructure for asserting includes in the query
2734a3f 
Remove AssertIncludeQuery which is based on queryable
Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter

Resolves #15368
smitpatel added a commit that referenced this issue May 15, 2020
@smitpatel
Tests : A better infrastructure for asserting includes in the query (#…
7f81b60 
…20958)

Remove AssertIncludeQuery which is based on queryable
Introduce AssertInclude method over element which can be used anywhere element asserter can be passed just like collection asserter

Resolves #15368
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview6 Jun 1, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview6, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Tests : A better infrastructure for asserting includes in the query dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar