Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider reverting change of log level for query execution #15888

Closed
divega opened this issue May 31, 2019 · 0 comments · Fixed by #16117
Closed

Consider reverting change of log level for query execution #15888

divega opened this issue May 31, 2019 · 0 comments · Fixed by #16117
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@divega
Copy link
Contributor

divega commented May 31, 2019 •
edited
Loading

In EF Core 3.0 preview 3 we changed the log level of queries from Info to Debug. This was based on some feedback indicating that the queries introduced too much noise at the info level.

But since then:

  • We have seen significant signals that many customers prefer the old default and that we may have reacted too quickly to small number of requests. For example:

    The best thing the EF Core team ever did was outputting the generated SQL to the VS Console when in debug. 😍

    — JimBobSquarePants (@James_M_South) May 3, 2019

  • We have added the ability to change the level at which queries are logged, so anyone that doesn't like to see the queries by default can now learn how to make them disappear.

Given this, we are considering reverting the change.
@ajcvickers ajcvickers self-assigned this Jun 3, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 3, 2019
ajcvickers added a commit that referenced this issue Jun 16, 2019
@ajcvickers
Revert log level change for generated SQL
1ffb620 
Fixes #15888

There is no clear consensus which log level is best, so instead of making a break we have made it easy to specify any level wanted.
This was referenced Jun 16, 2019
Merged
Closed
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 16, 2019
ajcvickers added a commit that referenced this issue Jun 17, 2019
@ajcvickers
Revert log level change for generated SQL
442750c 
Fixes #15888

There is no clear consensus which log level is best, so instead of making a break we have made it easy to specify any level wanted.
@JonPSmith JonPSmith mentioned this issue Jun 24, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Revert log level change for generated SQL dotnet/efcore
2 participants
@divega @ajcvickers