Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate IValueBufferFactoryFactory #15914

Closed
smitpatel opened this issue Jun 3, 2019 · 1 comment · Fixed by #27898
Closed

Investigate IValueBufferFactoryFactory #15914

smitpatel opened this issue Jun 3, 2019 · 1 comment · Fixed by #27898
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
7.0.0

Comments

@smitpatel
Copy link
Member

Query does not use it anymore. I saw it being linked in update pipeline.
@ajcvickers
Copy link
Member

We should look into moving the update pipeline code to use the data reader mechanics from the new query pipeline.

@ajcvickers ajcvickers added this to the Backlog milestone Jun 6, 2019
@AndriySvyryd AndriySvyryd self-assigned this Aug 23, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 7.0.0 Jan 21, 2022
@ajcvickers ajcvickers assigned roji and unassigned AndriySvyryd Apr 22, 2022
roji added a commit to roji/efcore that referenced this issue Apr 27, 2022
@roji
Remove ValueBuffer from update pipeline
526006e 
Closes dotnet#15914
@roji roji mentioned this issue Apr 27, 2022
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 27, 2022
roji added a commit to roji/efcore that referenced this issue May 2, 2022
@roji
Remove ValueBuffer from update pipeline
a48d29f 
Closes dotnet#15914
roji added a commit to roji/efcore that referenced this issue May 2, 2022
@roji
Remove ValueBuffer from update pipeline
f4bbcbb 
Closes dotnet#15914
@ghost ghost closed this as completed in #27898 May 2, 2022
ghost pushed a commit that referenced this issue May 2, 2022
@roji
Remove ValueBuffer from update pipeline (#27898)
64eec9d 
Closes #15914
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview5 May 4, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview5, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove ValueBuffer from update pipeline roji/efcore
4 participants
@ajcvickers @smitpatel @roji @AndriySvyryd