Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Equality: rewrite Contains, OrderBy #15939

Closed
roji opened this issue Jun 4, 2019 · 2 comments · Fixed by #16134
Closed

Entity Equality: rewrite Contains, OrderBy #15939

roji opened this issue Jun 4, 2019 · 2 comments · Fixed by #16134
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jun 4, 2019

Example code:

context.Orders.Where(o => o.CustomerID == "VINET")
                        .Contains(context.Orders.Single(o => o.OrderID == 10248));

From test Contains_over_entityType_should_rewrite_to_identity_equality.
@roji roji self-assigned this Jun 4, 2019
@roji roji mentioned this issue Jun 4, 2019
Merged
5 tasks
@maumar
Copy link
Contributor

maumar commented Jun 5, 2019

related to #15260

@smitpatel
Copy link
Contributor

Also rewrite OrderBy entityType to ordering by keys

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 6, 2019
@roji roji changed the title Entity Equality: rewrite Contains Entity Equality: rewrite Contains, OrderBy Jun 18, 2019
roji added a commit to roji/efcore that referenced this issue Jun 18, 2019
@roji
Implement entity equality Contains() support
4631d7f 
Fixes dotnet#15939
roji added a commit to roji/efcore that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
26fe88c 
Fixes dotnet#15939
roji added a commit to roji/efcore that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
f4ddbf0 
Fixes dotnet#15939
roji added a commit that referenced this issue Jun 18, 2019
@roji
Implement entity equality Contains() support
ad29d81 
Fixes #15939
roji added a commit that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
c6db9dc 
Fixes #15939
@roji roji mentioned this issue Jun 18, 2019
Merged
roji added a commit that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
954d752 
Fixes #15939
roji added a commit to roji/efcore that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
db4d117 
Fixes dotnet#15939
roji added a commit that referenced this issue Jun 18, 2019
@roji
Implement entity equality Contains() support
03dfa25 
Fixes #15939
roji added a commit that referenced this issue Jun 18, 2019
@roji
Implement entity equality OrderBy() support
6b60d6a 
Fixes #15939
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@smitpatel smitpatel mentioned this issue Jul 24, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Entity equality: Contains and OrderBy dotnet/efcore
4 participants
@ajcvickers @smitpatel @maumar @roji