Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Nav expansion failed to expand some navigations #16088

Closed
smitpatel opened this issue Jun 14, 2019 · 0 comments · Fixed by #17034
Closed

Query: Nav expansion failed to expand some navigations #16088

smitpatel opened this issue Jun 14, 2019 · 0 comments · Fixed by #17034
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Milestone

Comments

@smitpatel
Copy link
Contributor

[ConditionalTheory]
        [MemberData(nameof(IsAsyncData))]
        public virtual Task Manually_created_left_join_propagates_nullability_to_navigations(bool isAsync)
        {
            return AssertQuery<Level1, Level2>(
                isAsync,
                (l1s, l2s) =>
                    from l1_manual in l1s
                    join l2_manual in l2s on l1_manual.Id equals l2_manual.Level1_Optional_Id into grouping
                    from l2_manual in grouping.DefaultIfEmpty()
                    where l2_manual.OneToOne_Required_FK_Inverse2.Name != "L3 02"
                    select l2_manual.OneToOne_Required_FK_Inverse2.Name,
                (l1s, l2s) =>
                    from l1_manual in l1s
                    join l2_manual in l2s on l1_manual.Id equals l2_manual.Level1_Optional_Id into grouping
                    from l2_manual in grouping.DefaultIfEmpty()
                    where Maybe(l2_manual, () => l2_manual.OneToOne_Required_FK_Inverse2.Name) != "L3 02"
                    select Maybe(l2_manual, () => l2_manual.OneToOne_Required_FK_Inverse2.Name));
        }

OneToOne_Required_FK_Inverse2 is not expanded into join.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 14, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@smitpatel smitpatel added the verify-fixed This issue is likely fixed in new query pipeline. label Aug 7, 2019
@smitpatel smitpatel assigned smitpatel and unassigned maumar Aug 8, 2019
@smitpatel smitpatel removed the verify-fixed This issue is likely fixed in new query pipeline. label Aug 8, 2019
@smitpatel smitpatel modified the milestones: Backlog, 3.0.0 Aug 8, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 8, 2019
Fixed in new nav expansion

Close #16088
smitpatel added a commit that referenced this issue Aug 8, 2019
Fixed in new nav expansion

Close #16088
smitpatel added a commit that referenced this issue Aug 8, 2019
Fixed in new nav expansion

Close #16088
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants