Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Result mismatch likely due to null semantics #16093

Closed
smitpatel opened this issue Jun 14, 2019 · 3 comments · Fixed by #18767 or #18809
Closed

Query: Result mismatch likely due to null semantics #16093

smitpatel opened this issue Jun 14, 2019 · 3 comments · Fixed by #18767 or #18809
Assignees
@maumar
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member 

        [ConditionalTheory]
        [MemberData(nameof(IsAsyncData))]
        public virtual Task Contains_with_subquery_optional_navigation_and_constant_item(bool isAsync)
        {
            return AssertQuery<Level1>(
                isAsync,
                l1s => l1s.Where(l1 => l1.OneToOne_Optional_FK1.OneToMany_Optional2.Distinct().Select(l3 => l3.Id).Contains(1)),
                l1s => l1s.Where(
                    l1 => MaybeScalar<bool>(
                              l1.OneToOne_Optional_FK1,
                              () => l1.OneToOne_Optional_FK1.OneToMany_Optional2.Distinct().Select(l3 => l3.Id).Contains(1)) == true),
                elementSorter: e => e.Id,
                elementAsserter: (e, a) => Assert.Equal(e.Id, a.Id));
        }
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 14, 2019
@maumar
Copy link
Contributor

maumar commented Jun 19, 2019

related to #15798

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@maumar maumar removed this from the Backlog milestone Nov 5, 2019
@maumar
Copy link
Contributor

maumar commented Nov 5, 2019

dupe of #15798

maumar added a commit that referenced this issue Nov 5, 2019
@maumar
enable test for #16093
c71204c
@maumar maumar mentioned this issue Nov 5, 2019
Merged
maumar added a commit that referenced this issue Nov 5, 2019
@maumar
enable test for #16093
9c3b2af
@smitpatel smitpatel reopened this Nov 6, 2019
@smitpatel
Copy link
Member Author

There are more tests disabled with this issue number.

maumar added a commit that referenced this issue Nov 7, 2019
@maumar
Enable tests for #16093 - Query: Result mismatch likely due to null s…
d88b5e1 
…emantics

Also fixed a minor bug in expression printer, where we would print incorrect argument names for extension methods with 2+ arguments.

Resolves #16093
@maumar maumar mentioned this issue Nov 7, 2019
Merged
@maumar maumar added this to the 5.0.0 milestone Nov 7, 2019
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 7, 2019
@maumar maumar closed this as completed in d801c79 Nov 8, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers removed this from the 5.0.0-preview1 milestone Nov 7, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
3 participants
@ajcvickers @smitpatel @maumar