-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for...ThenInclude value cannot be null #16107
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
type-bug
Milestone
Comments
@kccsf - Thanks for reporting. I believe I know where the bug is. Repro is not necessary. :) |
No problem; thanks again for such speedy feedback! :-) |
@smitpatel to write a note on how to fix this. |
smitpatel
added
the
verify-fixed
This issue is likely fixed in new query pipeline.
label
Jul 24, 2019
Code change in #16212 should fix this. |
Thanks - working in 3.0.0-preview7.19365.7 |
@kccsf - Thanks for verifying. |
ajcvickers
changed the title
ThenInclude value cannot be null
Add test for...ThenInclude value cannot be null
Jul 24, 2019
smitpatel
added
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
and removed
verify-fixed
This issue is likely fixed in new query pipeline.
labels
Sep 20, 2019
smitpatel
added a commit
that referenced
this issue
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
type-bug
var test = await dbcontext.SomeEntity
.Include(x => x.SecondEntity).ThenInclude(x => x.ThirdEntity)
.SingleOrDefaultAsync(x => x.Id == id);
Fails when SecondEntity is null.
Works when ThenInclude is removed. Also works if SecondEntity is not null even if ThirdEntity is null.
Steps to reproduce
Have private repo if required
Further technical details
EF Core version: 3.0.0-preview7.19314.2
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2019 16.2.0 Preview 2
The text was updated successfully, but these errors were encountered: