Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: CosmosDbConfiguredConditionAttribute should catch only expected exception #16129

Closed
smitpatel opened this issue Jun 17, 2019 · 0 comments · Fixed by #16169
Closed

Cosmos: CosmosDbConfiguredConditionAttribute should catch only expected exception #16129

smitpatel opened this issue Jun 17, 2019 · 0 comments · Fixed by #16169
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

It uses EF to connect and catches all exceptions. Any exceptions arising from EF stack would skip test as if Emulator is not running. (Even though it is). This hides actual error.
@AndriySvyryd AndriySvyryd self-assigned this Jun 19, 2019
AndriySvyryd added a commit that referenced this issue Jun 20, 2019
@AndriySvyryd
Convert CosmosModelCustomizer to a convention.
47ad548 
Only catch expected exceptions in CosmosDbConfiguredConditionAttribute.

Fixes #16129
@AndriySvyryd AndriySvyryd mentioned this issue Jun 20, 2019
Merged
AndriySvyryd added a commit that referenced this issue Jun 20, 2019
@AndriySvyryd
Convert CosmosModelCustomizer to a convention.
618a69b 
Only catch expected exceptions in CosmosDbConfiguredConditionAttribute.

Fixes #16129
@AndriySvyryd AndriySvyryd added this to the 3.0 milestone Jun 20, 2019
@AndriySvyryd AndriySvyryd removed their assignment Jun 20, 2019
@divega divega modified the milestones: 3.0, 3.0.0 Jun 20, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Convert CosmosModelCustomizer to a convention. dotnet/efcore
4 participants
@divega @ajcvickers @smitpatel @AndriySvyryd