-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only 1 entity materalized although generated SQL returns more rows #16165
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
outer key selector is busted. |
This went away in the new implementation of the nav expanding support for set operations (probably because there's no attempt to not terminate). |
roji
added a commit
to roji/efcore
that referenced
this issue
Jun 25, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. dotnet#16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes dotnet#6812 Fixes dotnet#13196 Fixes dotnet#16065 Fixes dotnet#16165
roji
added a commit
that referenced
this issue
Jun 25, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. #16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes #6812 Fixes #13196 Fixes #16065 Fixes #16165
roji
added a commit
to roji/efcore
that referenced
this issue
Jun 26, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. dotnet#16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes dotnet#6812 Fixes dotnet#13196 Fixes dotnet#16065 Fixes dotnet#16165
roji
added a commit
to roji/efcore
that referenced
this issue
Jun 27, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. dotnet#16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes dotnet#6812 Fixes dotnet#13196 Fixes dotnet#16065 Fixes dotnet#16165
roji
added a commit
that referenced
this issue
Jun 27, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. #16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes #6812 Fixes #13196 Fixes #16065 Fixes #16165
roji
added a commit
to roji/efcore
that referenced
this issue
Jun 27, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. dotnet#16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes dotnet#6812 Fixes dotnet#13196 Fixes dotnet#16065 Fixes dotnet#16165
roji
added a commit
that referenced
this issue
Jun 27, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. #16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes #6812 Fixes #13196 Fixes #16065 Fixes #16165
roji
added a commit
that referenced
this issue
Jun 28, 2019
* Include/nav rewriting is now supported. * We now push down to subquery when OrderBy, Take or Skip are applied to set operations, to avoid using the hack where ColumnExpression with no table alias was used. #16244 was opened to track for post-3.0. * Added missing support for union over subselect projection mappings. * Added Other type to SetOperationType so that providers can define extra set operations (e.g. PostgreSQL `INTERSECT ALL`, `EXCEPT ALL`). Completes #6812 Fixes #13196 Fixes #16065 Fixes #16165
roji
added a commit
that referenced
this issue
Jun 28, 2019
roji
added a commit
that referenced
this issue
Jun 28, 2019
ajcvickers
added
propose-punt
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
query
and removed
propose-punt
labels
Jun 28, 2019
roji
added a commit
that referenced
this issue
Jul 1, 2019
roji
added a commit
that referenced
this issue
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
While working on set operations, I ran into a situation where generated SQL properly fetches 7 customers, but only one gets materialized. This can be reproduce with test Union_Include from https://github.com/roji/EntityFrameworkCore/tree/StateOfTheUnion.
Related to #15611 which generally tracks materialization.
/cc @maumar who already did some investigation on this.
The text was updated successfully, but these errors were encountered: