Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CoreAnnotationNames internal #17159

Closed
ajcvickers opened this issue Aug 14, 2019 · 2 comments · Fixed by #17210
Closed

Make CoreAnnotationNames internal #17159

ajcvickers opened this issue Aug 14, 2019 · 2 comments · Fixed by #17210
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

Used:

  • ProxyBindingRewriter uses CoreAnnotationNames.ConstructorBinding
  • SqlServerModelValidator uses CoreAnnotationNames.TypeMapping
@ajcvickers ajcvickers mentioned this issue Aug 14, 2019
Closed
@ajcvickers
Copy link
Member Author

See also #17160 for relational annotations.

@ajcvickers
Copy link
Member Author

For the first one, just use internal
For second one, add API to ask for the metadata we need--e.g. configuration source.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 16, 2019
@ajcvickers ajcvickers self-assigned this Aug 16, 2019
AndriySvyryd added a commit that referenced this issue Aug 16, 2019
@AndriySvyryd
Add GetTypeMappingConfigurationSource
e9ffcb9 
Part of #17159
This was referenced Aug 16, 2019
Merged
Closed
AndriySvyryd added a commit that referenced this issue Aug 16, 2019
@AndriySvyryd
Add GetTypeMappingConfigurationSource
881790b 
Part of #17159
@ajcvickers ajcvickers mentioned this issue Aug 16, 2019
Closed
ajcvickers added a commit that referenced this issue Aug 16, 2019
@ajcvickers
Make CoreAnnotationNames internal
f45d4fb 
Fixes #17159
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 16, 2019
@ajcvickers ajcvickers mentioned this issue Aug 16, 2019
Merged
ajcvickers added a commit that referenced this issue Aug 17, 2019
@ajcvickers
Make CoreAnnotationNames internal
765778c 
Fixes #17159
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Make CoreAnnotationNames internal dotnet/efcore
1 participant
@ajcvickers