Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of expressions in client evaluation exception #17236

Closed
ajcvickers opened this issue Aug 18, 2019 · 2 comments · Fixed by #18228
Closed

Improve readability of expressions in client evaluation exception #17236

ajcvickers opened this issue Aug 18, 2019 · 2 comments · Fixed by #18228
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.1.0

Comments

@ajcvickers
Copy link
Member

Scrub the places where the exception is thrown and ensure:

  • The most appropriate expression to print is being used
  • The result of printing the expression can be correlated with the code that was written
ajcvickers added a commit that referenced this issue Aug 18, 2019
@ajcvickers
Throw better exception message for client eval
f53e234 
Fixes #16133 and also partial fix for #15937

This is far from perfect and needs some further work. For example, see #17236

No issues reference #14935 any more; new issues cover things not fixed here but which were refeceing that issue.
@ajcvickers ajcvickers mentioned this issue Aug 18, 2019
Merged
ajcvickers added a commit that referenced this issue Aug 19, 2019
@ajcvickers
Throw better exception message for client eval
b6614de 
Fixes #16133 and also partial fix for #15937

This is far from perfect and needs some further work. For example, see #17236

No issues reference #14935 any more; new issues cover things not fixed here but which were refeceing that issue.
ajcvickers added a commit that referenced this issue Aug 19, 2019
@ajcvickers
Throw better exception message for client eval
76bd379 
Fixes #16133 and also partial fix for #15937

This is far from perfect and needs some further work. For example, see #17236

No issues reference #14935 any more; new issues cover things not fixed here but which were refeceing that issue.
ajcvickers added a commit that referenced this issue Aug 19, 2019
@ajcvickers
Throw better exception message for client eval
aca4958 
Fixes #16133 and also partial fix for #15937

This is far from perfect and needs some further work. For example, see #17236

No issues reference #14935 any more; new issues cover things not fixed here but which were refeceing that issue.
@ajcvickers
Copy link
Member Author

Also consider if the actual exception message should be changed to something more specific than just translation/query processing failed.

smitpatel pushed a commit that referenced this issue Aug 21, 2019
@ajcvickers @smitpatel
Throw better exception message for client eval
6f0a799 
Fixes #16133 and also partial fix for #15937

This is far from perfect and needs some further work. For example, see #17236

No issues reference #14935 any more; new issues cover things not fixed here but which were refeceing that issue.
@ajcvickers ajcvickers added this to the 3.1.0 milestone Aug 23, 2019
@ajcvickers
Copy link
Member Author

Note from triage: we cleaned this up a lot in the 3.0 code already, so this is probably just a quick scrub to make sure that the expressions we include look reasonable.

maumar added a commit that referenced this issue Oct 4, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
d22589e 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying Enumerable/Queryable methods (e.g. Where, Select, Join) as extension methods
- simplifying display of Navigation object

Also fixed minor display bugs in expression printer.
maumar added a commit that referenced this issue Oct 5, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
124e869 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying Enumerable/Queryable methods (e.g. Where, Select, Join) as extension methods
- simplifying display of Navigation object

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
@maumar maumar mentioned this issue Oct 5, 2019
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 5, 2019
maumar added a commit that referenced this issue Oct 16, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
d726765 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying Enumerable/Queryable methods (e.g. Where, Select, Join) as extension methods
- simplifying display of Navigation object

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
f1e0001 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
350facc 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
2ffc3f4 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
3c374ca 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
e84ac2c 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
maumar added a commit that referenced this issue Oct 17, 2019
@maumar
Fix to #17236 - Improve readability of expressions in client evaluati…
7285557 
…on exception

Adding a new switch to ExpressionPrinter that creates simplified output for Print and verbose (i.e. what we had before this change) for PrintDebug.
Simplified output means:
- displaying extension methods as extension methods rather than regular static methods,
- simplifying display of Navigation object,
- not showing if lambda body references parameter that is out of scope.

Also fixed minor display bugs in expression printer.

Also some changes in testing:
- added unit tests for ExpressionPrinter,
- DRY the "translation failed" tests,
- "translation failed" tests no longer verify expression in the exception message and instead just make sure that right exception is thrown.
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview2 Oct 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview2, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Fix to #17236 - Improve readability of expressions in client evaluation exception dotnet/efcore
2 participants
@ajcvickers @maumar