Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Convert 'apply' with skip to row number filtering #17326

Closed
smitpatel opened this issue Aug 21, 2019 · 0 comments · Fixed by #21282
Closed

Query: Convert 'apply' with skip to row number filtering #17326

smitpatel opened this issue Aug 21, 2019 · 0 comments · Fixed by #21282
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

Currently only Limit is processed. We can also do same for offset.
@ajcvickers ajcvickers changed the title Query: Convert lateral joins with skip to row number filtering Query: Convert 'apply' with skip to row number filtering Aug 23, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Aug 23, 2019
@smitpatel smitpatel mentioned this issue Mar 16, 2020
Closed
@smitpatel smitpatel mentioned this issue Apr 8, 2020
Merged
@smitpatel smitpatel self-assigned this Jun 16, 2020
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Jun 16, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 16, 2020
smitpatel added a commit that referenced this issue Jun 16, 2020
@smitpatel
Query: Convert "APPLY" to "JOIN" with skip via RowNumber
486dfc2 
Resolves #17326

This enables filtered include with skip to be translated for Sqlite
@smitpatel smitpatel mentioned this issue Jun 16, 2020
Merged
smitpatel added a commit that referenced this issue Jun 16, 2020
@smitpatel
Query: Convert "APPLY" to "JOIN" with skip via RowNumber
7267c65 
Resolves #17326

This enables filtered include with skip to be translated for Sqlite
smitpatel added a commit that referenced this issue Jun 16, 2020
@smitpatel
Query: Convert "APPLY" to "JOIN" with skip via RowNumber (#21282)
2c0a6ae 
Resolves #17326

This enables filtered include with skip to be translated for Sqlite
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Convert "APPLY" to "JOIN" with skip via RowNumber dotnet/efcore
2 participants
@ajcvickers @smitpatel