Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational: Client eval warning is thrown from method rather than base #17387

Closed
smitpatel opened this issue Aug 22, 2019 · 0 comments
Closed
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@smitpatel
Copy link
Contributor

When we fixed issue to throw better exception message when client eval, we refactored code as pattern that Translate* methods would return null and base will throw exception. For some reason, relational is not following the pattern. This causes the expression tree printed to be different. Modifying some tests not to verify the message. It would be more useful to print from base given it gives better understanding to customers that why translation failed.

@smitpatel smitpatel self-assigned this Aug 22, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 23, 2019
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug labels Aug 23, 2019
@bricelam bricelam modified the milestones: 3.0.0, 3.0.0-rc1 Sep 16, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-rc1, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants