Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose ICurrentDbContext on QueryCompilationContextDependencies #17845

Closed
AndriySvyryd opened this issue Sep 14, 2019 · 1 comment · Fixed by #18973
Closed

Don't expose ICurrentDbContext on QueryCompilationContextDependencies #17845

AndriySvyryd opened this issue Sep 14, 2019 · 1 comment · Fixed by #18973
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

Only the type of the context is actually used
@divega divega added this to the Backlog milestone Sep 16, 2019
@smitpatel
Copy link
Contributor

We also used ChangeTracker from Context.
IsTracking = context.ChangeTracker.QueryTrackingBehavior == QueryTrackingBehavior.TrackAll;

@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Nov 19, 2019
@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed propose-close labels Nov 19, 2019
smitpatel added a commit that referenced this issue Nov 19, 2019
@smitpatel
Query: Don't expose ICurrentDbContext on QCCD
ab5c476 
Resolves #17845
@smitpatel smitpatel mentioned this issue Nov 19, 2019
Merged
smitpatel added a commit that referenced this issue Nov 19, 2019
@smitpatel
Query: Don't expose ICurrentDbContext on QCCD
8e17a77 
Resolves #17845
smitpatel added a commit that referenced this issue Nov 19, 2019
@smitpatel
Query: Don't expose ICurrentDbContext on QCCD
25af0b1 
Resolves #17845
smitpatel added a commit that referenced this issue Nov 19, 2019
@smitpatel
Query: Don't expose ICurrentDbContext on QCCD (#18973)
9b6d5c1 
Resolves #17845
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Don't expose ICurrentDbContext on QCCD dotnet/efcore
4 participants
@divega @ajcvickers @smitpatel @AndriySvyryd