Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ColumnModification #17946

Closed
AndriySvyryd opened this issue Sep 19, 2019 · 2 comments · Fixed by #25327
Closed

Refactor ColumnModification #17946

AndriySvyryd opened this issue Sep 19, 2019 · 2 comments · Fixed by #25327
Labels
area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup type-enhancement
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Sep 19, 2019 •
edited
Loading

  • UseCurrentValueParameter , UseOriginalValueParameter -> UseCurrentValue, UseOriginalValue, UseParameter (Entry != null)
  • Review Value implementation
  • Review usage in UpdateSqlGenerator, MigrationsModelDiffer and data operations
@AndriySvyryd AndriySvyryd self-assigned this Sep 19, 2019
@smitpatel smitpatel added this to the Backlog milestone Sep 20, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 16, 2020
@ajcvickers ajcvickers mentioned this issue Dec 16, 2020
Closed
@ajcvickers
Copy link
Contributor

While working on this also consider #23027

@AndriySvyryd
Copy link
Member Author

Notes from PR:
The ColumnModification is tightly coupled with ModificationCommand, so it would be more appropriate to have an IModificationCommandSource. In the future it could also be used to pool ModificationCommand instances.

The signature for the factory method should be ModificationCommand Create(ModificationCommandParameters) to avoid breaking changes if we need to change the passed in parameters.

ModificationCommand would need a ColumnModification AddColumnModification(ColumnModificationParameters) method for internal and MigrationsSqlGenerator use.

@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed providers-beware labels Jul 23, 2021
@AndriySvyryd AndriySvyryd removed their assignment Jul 23, 2021
AndriySvyryd added a commit that referenced this issue Jul 23, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
3e09e08 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
@AndriySvyryd AndriySvyryd mentioned this issue Jul 23, 2021
Merged
AndriySvyryd added a commit that referenced this issue Jul 23, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
a0e9e2f 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 24, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
721fe78 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 26, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
a53cb61 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 26, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
d5c42be 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 26, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
e0a8237 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 26, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
1c02b4d 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 26, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
94eaea9 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
AndriySvyryd added a commit that referenced this issue Jul 27, 2021
@AndriySvyryd @dmitry-lipetsk
Add IColumnModification and IModificationCommand to allow the impleme…
0d8959d 
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup type-enhancement
Projects
None yet
Milestone
6.0.0
3 participants
@ajcvickers @smitpatel @AndriySvyryd