Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Equality: make sure all expression types are covered #18379

Closed
roji opened this issue Oct 15, 2019 · 0 comments · Fixed by #18400
Closed

Entity Equality: make sure all expression types are covered #18379

roji opened this issue Oct 15, 2019 · 0 comments · Fixed by #18400
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.1.0

Comments

@roji
Copy link
Member

roji commented Oct 15, 2019

Following #17744, we should make sure there aren't any additional unwrapped expression types that entity equality doesn't handle. The goal isn't to flow entity information for composition, just to make sure that all expression trees leaving the visitor have no EntityReferenceExpression wrappers (especially important to support arbitrary things in top-most projections).
@roji roji added the type-bug label Oct 15, 2019
@roji roji self-assigned this Oct 15, 2019
@roji roji mentioned this issue Oct 15, 2019
Closed
roji added a commit that referenced this issue Oct 16, 2019
@roji
Handle ListInitExpression in entity equality
7e07b2b 
Closes #18379
@roji roji mentioned this issue Oct 16, 2019
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 16, 2019
@ajcvickers ajcvickers added this to the 3.1.0 milestone Oct 18, 2019
roji added a commit that referenced this issue Oct 22, 2019
@roji
Handle ListInitExpression in entity equality
e0a1d68 
Closes #18379
roji added a commit that referenced this issue Oct 22, 2019
@roji
Handle ListInitExpression in entity equality
f325945 
Closes #18379
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview2 Oct 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview2, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Handle ListInitExpression in entity equality dotnet/efcore
2 participants
@ajcvickers @roji