Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: clean-up expression printer when we can do breaking changes #18413

Closed
maumar opened this issue Oct 17, 2019 · 1 comment · Fixed by #18763
Closed

Query: clean-up expression printer when we can do breaking changes #18413

maumar opened this issue Oct 17, 2019 · 1 comment · Fixed by #18763
Assignees
@maumar
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Oct 17, 2019

We can make expression printer internal, since we expose Print method on ExpressionExtensions

Also, currently we repurposed 'generateUniqueParameterIds' to mean general optimized vs debug output. We should rename it to something more appropriate.
@maumar maumar self-assigned this Oct 17, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Oct 18, 2019
@ajcvickers
Copy link
Member

Note from triage: make sure not to break providers and not to force providers to use internal code when doing this.

maumar added a commit that referenced this issue Nov 5, 2019
@maumar
ExpressionPrinter fixes/cleanup
f907737 
Fix to #18709 - Query: expression printer should still print type argument for Cast and OfType
Fix to #18413 - Query: clean-up expression printer when we can do breaking changes

Resolves #18709
Resolves #18413
@maumar maumar mentioned this issue Nov 5, 2019
Merged
@maumar maumar modified the milestones: Backlog, 5.0.0 Nov 5, 2019
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 5, 2019
@maumar maumar closed this as completed in 37f0135 Nov 5, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

ExpressionPrinter fixes/cleanup dotnet/efcore
2 participants
@ajcvickers @maumar