Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpressionEqualityComparer cleanup #18685

Closed
smitpatel opened this issue Oct 31, 2019 · 1 comment · Fixed by #19271
Closed

ExpressionEqualityComparer cleanup #18685

smitpatel opened this issue Oct 31, 2019 · 1 comment · Fixed by #19271
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

Use switch on Type rather than NodeType.
Add hashcode computation for missing nodes

  • BlockExpression
  • AssignExpression
@smitpatel smitpatel added type-cleanup good first issue This issue should be relatively straightforward to fix. labels Oct 31, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Nov 1, 2019
@ramanathanv
Copy link

Hi @smitpatel , @ajcvickers ,
I would like to resolve this issue as a first contribution.
I noticed that there are 5 places in 4 classes where there is a switch statement against NodeType.
ExpressionPrinter.cs, ExpressionEqualityComparer.cs, CSharpHelper.cs, RelationalSqlTranslatingExpressionVisitor.cs.
Can you provide some additional explanation on the issue to help me get going with this?

@smitpatel smitpatel mentioned this issue Nov 20, 2019
Closed
@smitpatel smitpatel mentioned this issue Dec 10, 2019
Closed
smitpatel added a commit that referenced this issue Dec 11, 2019
@smitpatel
Query: Clean up in ExpressionEqualityComparer
5d0344e 
Resolves #18685
Resolves #10529
Resolves #17959
@smitpatel smitpatel mentioned this issue Dec 11, 2019
Merged
smitpatel added a commit that referenced this issue Dec 11, 2019
@smitpatel
Query: Clean up in ExpressionEqualityComparer
4920872 
Resolves #18685
Resolves #10529
Resolves #17959
smitpatel added a commit that referenced this issue Dec 11, 2019
@smitpatel
Query: Clean up in ExpressionEqualityComparer
a6c394d 
Resolves #18685
Resolves #10529
Resolves #17959
@smitpatel smitpatel self-assigned this Dec 12, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 12, 2019
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Dec 12, 2019
smitpatel added a commit that referenced this issue Dec 12, 2019
@smitpatel
Query: Clean up in ExpressionEqualityComparer
82b0019 
Resolves #18685
Resolves #10529
Resolves #17959
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Clean up in ExpressionEqualityComparer dotnet/efcore
3 participants
@ajcvickers @smitpatel @ramanathanv