Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: copy-paste error in the SelectExpression Equals method, could lead to null refs/other errors #18940

Closed
maumar opened this issue Nov 16, 2019 · 1 comment · Fixed by #18941
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@maumar
Copy link
Contributor

maumar commented Nov 16, 2019

SelectExpression -> private bool Equals(SelectExpression selectExpression)

code:

            if (!(Having == null && selectExpression.Having == null
                || Having != null && Predicate.Equals(selectExpression.Having)))
            {
                return false;
            }

should be:

            if (!(Having == null && selectExpression.Having == null
                || Having != null && Having.Equals(selectExpression.Having)))
            {
                return false;
            }
@smitpatel
Copy link
Contributor

Should use Equals(Having, selectExpression.Having) as @AndriySvyryd suggested at some point.

maumar added a commit that referenced this issue Nov 16, 2019
…tor into ParameterValueBasedSelectExpressionOptimizer

Using DI to create parameter value based postprocessor, which allows for provider-specific optimizations, including SearchConditionConvertingExpressionVisitor

Resolves #18492
Resolved #18940
maumar added a commit that referenced this issue Nov 16, 2019
…tor into ParameterValueBasedSelectExpressionOptimizer

Using DI to create parameter value based postprocessor, which allows for provider-specific optimizations, including SearchConditionConvertingExpressionVisitor

Resolves #18492
Resolved #18940
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 18, 2019
maumar added a commit that referenced this issue Nov 19, 2019
…tor into ParameterValueBasedSelectExpressionOptimizer

Using DI to create parameter value based postprocessor, which allows for provider-specific optimizations, including SearchConditionConvertingExpressionVisitor

Resolves #18492
Resolved #18940
@maumar maumar closed this as completed in cb6bb76 Nov 19, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 20, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
3 participants