Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: add support for convert to/from bool value using Convert.To* methods #19606

Closed
maumar opened this issue Jan 15, 2020 · 1 comment · Fixed by #21163
Closed

Query: add support for convert to/from bool value using Convert.To* methods #19606

maumar opened this issue Jan 15, 2020 · 1 comment · Fixed by #21163
Assignees
@maumar
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Jan 15, 2020

We dont support bool currently. Could be useful in some cases, e.g. #19553
@maumar maumar changed the title Query: add support for convert to/from bool value using ConvertTo methods Query: add support for convert to/from bool value using Convert.To* methods Jan 15, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jan 17, 2020
@maumar maumar mentioned this issue Jun 6, 2020
Closed
maumar added a commit that referenced this issue Jun 6, 2020
@maumar
Fix to #19606 - Query: add support for convert to/from bool value usi…
1f5d70d 
…ng Convert.To* methods

Fixes #19606
@maumar maumar mentioned this issue Jun 6, 2020
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 6, 2020
maumar added a commit that referenced this issue Jun 6, 2020
@maumar
Fix to #19606 - Query: add support for convert to/from bool value usi…
b3dbfb1 
…ng Convert.To* methods

Fixes #19606
maumar added a commit that referenced this issue Jun 6, 2020
@maumar
Fix to #19606 - Query: add support for convert to/from bool value usi…
357f370 
…ng Convert.To* methods

Fixes #19606
maumar added a commit that referenced this issue Jun 7, 2020
@maumar
Fix to #19606 - Query: add support for convert to/from bool value usi…
a285a2e 
…ng Convert.To* methods

Fixes #19606
@maumar maumar closed this as completed in 252dee5 Jun 8, 2020
@roji
Copy link
Member

roji commented Jun 19, 2020

FYI in PostgreSQL converting to/from bool is disallowed (a bit like in C#). I'll be disabling these tests.

@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@maumar maumar mentioned this issue Jul 24, 2020
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
3 participants
@ajcvickers @maumar @roji