Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining clean up for migration tests #19668

Open
4 tasks
roji opened this issue Jan 22, 2020 · 1 comment
Open
4 tasks

Remaining clean up for migration tests #19668

roji opened this issue Jan 22, 2020 · 1 comment
Assignees
@roji
Labels
area-migrations area-test type-cleanup
Milestone
MQ

Comments

@roji
Copy link
Member

roji commented Jan 22, 2020 •
edited by AndriySvyryd
Loading

After #19039 is merged, we have some of the following cleanup to do:

  • Make sure Create_index_unique_with_include_and_filter_online actually runs on CI (SqlServerCondition.SupportsOnlineIndexes needs to be true)
  • Go over ModelDifferTests and remove everything already covered by the new functional migration tests
  • Go over remaining tests in MigrationSqlGeneratorTestBase and see if they make sense. Possibly move them to the functional test suite or remove if they have no value.
  • Go over MigrationsInfrastructureTestBase
@roji roji mentioned this issue Jan 23, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jan 24, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Mar 12, 2020
@bricelam bricelam removed their assignment Aug 10, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers
Copy link
Contributor

See also:

This was referenced Sep 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-test type-cleanup
Projects
None yet
Milestone
MQ
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @roji