Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Test using snapshot #11193

Closed
AndriySvyryd opened this issue Mar 8, 2018 · 5 comments · Fixed by #27031
Closed

Migrations: Test using snapshot #11193

AndriySvyryd opened this issue Mar 8, 2018 · 5 comments · Fixed by #27031
Assignees
Labels
area-migrations area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-6.0 type-enhancement
Milestone

Comments

@AndriySvyryd
Copy link
Member

The test suite with most scenarios for migrations - MigrationsModelDifferTest currently doesn't use the product pipeline to run the tests. It creates two models and then diffs them. Whereas the product generates a snapshot of the first model, compiles it, loads it and then diffs it with the second model.

The model snapshot could be significantly different from the model (e.g. it uses different CLR types for properties that have a value conversion). And we are missing cases where the generated code doesn't compile at all.

However doing this for every test case might be too slow.

@ajcvickers ajcvickers added this to the Backlog milestone Mar 9, 2018
@bricelam bricelam changed the title Migrations lacks test coverage Migrations: Test using snapshot Mar 13, 2018
@bricelam bricelam self-assigned this Nov 4, 2019
@roji roji removed this from the Backlog milestone May 6, 2020
@roji
Copy link
Member

roji commented May 6, 2020

Is this a dup of #20157?

@smitpatel
Copy link
Contributor

@roji - They are related.
Source model should be built from a snapshot. (tracked here)
Target model should be built using conventions (tracked in #20157)

@roji
Copy link
Member

roji commented May 6, 2020

OK, probably good to tackle together...

@ajcvickers
Copy link
Member

See also:

@roji
Copy link
Member

roji commented Dec 17, 2021

Poaching

@roji roji assigned roji and unassigned bricelam and AndriySvyryd Dec 17, 2021
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 17, 2021
@ajcvickers ajcvickers modified the milestones: MQ, 7.0.0 Jan 31, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migrations area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-6.0 type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants