-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations: Test using snapshot #11193
Labels
area-migrations
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
punted-for-6.0
type-enhancement
Milestone
Comments
bricelam
changed the title
Migrations lacks test coverage
Migrations: Test using snapshot
Mar 13, 2018
Is this a dup of #20157? |
OK, probably good to tackle together... |
4 tasks
See also:
|
Poaching |
roji
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Dec 17, 2021
roji
added a commit
that referenced
this issue
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-migrations
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
punted-for-6.0
type-enhancement
The test suite with most scenarios for migrations -
MigrationsModelDifferTest
currently doesn't use the product pipeline to run the tests. It creates two models and then diffs them. Whereas the product generates a snapshot of the first model, compiles it, loads it and then diffs it with the second model.The model snapshot could be significantly different from the model (e.g. it uses different CLR types for properties that have a value conversion). And we are missing cases where the generated code doesn't compile at all.
However doing this for every test case might be too slow.
The text was updated successfully, but these errors were encountered: