-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra methods/properties in SpatialQueryTestBase #19957
Comments
👍 Adding them to SpatialQueryTestBase is the right thing to do since it'll force other providers to think about whether or not they can be translated. One question: How are you handling the XmlReader of ToGMLFeature()? Only translating it if it's chained with ReadOuterXml()?
|
I'll admit I didn't think this far into my process... I just happened to be starting with the other ones and noticed they were missing, but it seems to make sense to only translate it if it's chained with ReadOuterXml(0. |
Another possibility: #19991 |
@EricStG We discussed this and concluded that maybe you should try just |
@ajcvickers Works for me, thanks! |
Added related stubs to Sqlite and SqlServer spatial tests
- Added related stubs to Sqlite and SqlServer spatial tests Part of dotnet#19957
- Added related stubs to Sqlite and SqlServer spatial tests Part of #19957
I'm adding new translations to npgsql/efcore.pg#457 and noticed that support in
SpatialQueryTestBase
was missing for some of them, namely:I'd like those methods and properties to be supported by the
SpatialQueryTestBase
class.I can submit a PR if the project is open to those changes.
The text was updated successfully, but these errors were encountered: