Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: add partition key to the PK #20509

Closed
AndriySvyryd opened this issue Apr 3, 2020 · 0 comments · Fixed by #21243
Closed

Cosmos: add partition key to the PK #20509

AndriySvyryd opened this issue Apr 3, 2020 · 0 comments · Fixed by #21243
Labels
area-cosmos breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 3, 2020 •
edited
Loading

Currently it's only added to the alternate key that includes id.

Throw if it's not part of any key and issue a warning when using Find when the partition key is not part of the PK
@ajcvickers ajcvickers added this to the 5.0.0 milestone Apr 3, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Apr 17, 2020
Merged
AndriySvyryd added a commit that referenced this issue Jun 12, 2020
@AndriySvyryd
Cosmos: add partition key to the PK
8bb4162 
Add model building tests for Cosmos and fix found bugs.

Fixes #20509
@AndriySvyryd AndriySvyryd mentioned this issue Jun 12, 2020
Merged
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 12, 2020
@AndriySvyryd AndriySvyryd removed their assignment Jun 12, 2020
AndriySvyryd added a commit that referenced this issue Jun 12, 2020
@AndriySvyryd
Cosmos: add partition key to the PK
74acd70 
Add model building tests for Cosmos and fix found bugs.

Fixes #20509
AndriySvyryd added a commit that referenced this issue Jun 12, 2020
@AndriySvyryd
Cosmos: add partition key to the PK
2e1333e 
Add model building tests for Cosmos and fix found bugs.

Fixes #20509
@AndriySvyryd AndriySvyryd mentioned this issue Jun 21, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos: add partition key to the key dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd