Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalSequenceBuilder uses internal API to obtain the IConventionModelBuilder #20561

Closed
ajcvickers opened this issue Apr 7, 2020 · 0 comments · Fixed by #20674
Closed

InternalSequenceBuilder uses internal API to obtain the IConventionModelBuilder #20561

ajcvickers opened this issue Apr 7, 2020 · 0 comments · Fixed by #20674
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member 

Builder = new InternalSequenceBuilder(this, ((Model)model).Builder.ModelBuilder);

This is now the only place in Relational where we're suppressing the warning for internal code usage.
@ajcvickers ajcvickers added this to the Backlog milestone Apr 13, 2020
AndriySvyryd added a commit that referenced this issue Apr 17, 2020
@AndriySvyryd
Add complex mapping support to the update pipeline
b59142a 
Part of #2266
Fixes #20561
@AndriySvyryd AndriySvyryd mentioned this issue Apr 17, 2020
Merged
AndriySvyryd added a commit that referenced this issue Apr 19, 2020
@AndriySvyryd
Add complex mapping support to the update pipeline
3cbc099 
Part of #2266
Fixes #20561
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 5.0.0 Apr 19, 2020
@AndriySvyryd AndriySvyryd removed their assignment Apr 19, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 19, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add complex mapping support to the update pipeline dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd