Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Disallow FromSql on TPT/TPC #21508

Closed
smitpatel opened this issue Jul 3, 2020 · 2 comments · Fixed by #21725
Closed

Query: Disallow FromSql on TPT/TPC #21508

smitpatel opened this issue Jul 3, 2020 · 2 comments · Fixed by #21725
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

Currently it is likely to just fail abruptly. We can either make it work or throw when used on TPT hierarchy.
@smitpatel smitpatel self-assigned this Jul 3, 2020
This was referenced Jul 3, 2020
Closed
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jul 6, 2020
@smitpatel
Copy link
Contributor Author

@AndriySvyryd - Throw or allow? Same would be applicable to TVFs

@AndriySvyryd
Copy link
Member

Throw. FromSql support tracked by #21627. TVF tracked by #19970

@smitpatel smitpatel changed the title Query: Allow FromSql on TPT/TPC Query: Disallow FromSql on TPT/TPC Jul 22, 2020
smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Disallow FromSql/TVF with TPT
2fec804 
- Throw exception when using FromSql* methods
- Throw if a TVF is mapped to TPT
- Throw if construction of SelectExpression with custom TableExpression is done when TPT

Resolves #21508
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 22, 2020
@smitpatel smitpatel mentioned this issue Jul 22, 2020
Merged
smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Disallow FromSql/TVF with TPT
65c6fac 
- Throw exception when using FromSql* methods
- Throw if a TVF is mapped to TPT
- Throw if construction of SelectExpression with custom TableExpression is done when TPT

Resolves #21508
@ghost ghost closed this as completed in #21725 Jul 22, 2020
ghost pushed a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Disallow FromSql/TVF with TPT (#21725)
b23e0ac 
- Throw exception when using FromSql* methods
- Throw if a TVF is mapped to TPT
- Throw if construction of SelectExpression with custom TableExpression is done when TPT

Resolves #21508
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Disallow FromSql/TVF with TPT dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd