Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServer RevEng: Scaffold Included index columns #22150

Open
Tracked by #22948
bricelam opened this issue Aug 20, 2020 · 3 comments
Open
Tracked by #22948

SqlServer RevEng: Scaffold Included index columns #22150

bricelam opened this issue Aug 20, 2020 · 3 comments

Comments

@bricelam
Copy link
Contributor

See #22148 (comment)

We need a new provider hook to handle annotations when we copy them from ITableIndex to IIndex.

@ajcvickers
Copy link
Member

The workaround for this is to find and replace where the names are wrong after performing the scaffolding. Please up-vote this issue if you're hitting it.

@richardthombs
Copy link

I've just hit this in a large database where all the key fields are suffixed with "ID". The scaffolding produces properties with a camel cased "Id" suffix, but the IncludeProperties still references the original database column name with the uppercase "ID".

Incidentally, it would be lovely if the error message made mention of which index has failed validation.

@bricelam
Copy link
Contributor Author

PR #23083 removes the code to scaffold them entirely. Re-purposing this issue to add them back as part of fixing the original problem.

@bricelam bricelam removed the type-bug label Oct 23, 2020
@bricelam bricelam changed the title SqlServer RevEng: Included index columns with renamed properties aren't handled SqlServer RevEng: Scaffold Included index columns Oct 23, 2020
ajcvickers pushed a commit that referenced this issue Oct 24, 2020
More people are hitting #22150 than we anticipated. Give that this configuration isn't needed when mapping to an existing column, we've decided to stop scaffolding them entirely until we can fix that particular issue.
@bricelam bricelam removed their assignment Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants