Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt into more compiler warnings #22295

Open
roji opened this issue Aug 28, 2020 · 0 comments
Open

Opt into more compiler warnings #22295

roji opened this issue Aug 28, 2020 · 0 comments
Assignees
@roji
Labels
area-global type-enhancement
Milestone
MQ

Comments

@roji
Copy link
Member

roji commented Aug 28, 2020

Blog post: https://devblogs.microsoft.com/dotnet/automatically-find-latent-bugs-in-your-code-with-net-5/

I think we should consider setting <AnalysisLevel> to latest, which means getting new warnings as we update our compiler (SDK). Otherwise pinning to level 5 (the current maximum), which is what you get by the default when you target net5.0.
@ajcvickers ajcvickers added this to the MQ milestone Aug 28, 2020
roji added a commit that referenced this issue Sep 18, 2020
@roji
Set <AnalysisLevel> to latest
2044aff 
Closes #22295
@roji roji mentioned this issue Sep 18, 2020
Closed
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 18, 2020
@ajcvickers ajcvickers removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-global type-enhancement
Projects
None yet
Milestone
MQ
Development

Successfully merging a pull request may close this issue.

Set <AnalysisLevel> to latest dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd