-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests using current culture #22901
Comments
Suggested fix for this in #23437 This solution changes thread culture since |
This is probably mostly a dup of #14912 (i.e. not a product bug), clearing milestone to put it in MQ for handling with that issue. |
@roji @ajcvickers Updated with current state (EF 8) |
Thanks @ErikEJ! |
Notes from triage:
|
@cincuranet Is this all fixed now? |
@cincuranet Ping? Is this all fixed now? |
Tests now explicitly set English locale (done in #33291). So the biggest pain point should be fixed. Can you validate it on your side? |
Other than connection pool starvation errors, the only one I see is this, both for Sqlite and SQL Server
|
That happened to me yesterday as well (when running locally) and then it went away. 🤷♂️ We need to investigate why it started happening. |
@cincuranet Any suggestions for:
I will switch from localdb to a SQL 2022 instance. |
After updating to a SQL 2022 instance, all tests pass except the two mentioned above |
The assertion failure makes me believe that it might be a regression caused by the changes to the translation of equality in #34072, but locally I am not able to reproduce (and it looks like the CI is not hitting this either). |
@ranma42 I am using Danish locale just FYI |
I tried running the test suite with
but I am not yet in the right setup to trigger the assertion 🤔 |
@ranma42 I do not understand your incantations - notice that I am on Windows |
Oops! when contributing to open-source I tend to assume *nix environments, but for dotnet-related projects that is definitely not the standard 😅 |
My system is using Danish regional settings.
Microsoft.EntityFrameworkCore.Relational.Tests.dll
Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll
Microsoft.EntityFrameworkCore.InMemory.FunctionalTests.dll
EFCore.SQLite.FunctionalTests.dll
Include provider and version information
EF Core version: 8.0 latest main
Database provider: N/A
Target framework: .NET 8.0
Operating system: Windows 11
IDE: e.g. Visual Studio 2022 17.8
The text was updated successfully, but these errors were encountered: