Foreign keys for tables marked as ExcludeFromMigrations regenerated in every migrations

[vitaliy-leschenko]

Foreign keys for tables marked as ExcludeFromMigrations regenerate in every migrations

Code sample

    public class ApplicationDbContext : DbContext, IApplicationDbContext
    {
        public DbSet<PhotoItem> PhotoItems { get; set; }
        public DbSet<LabImage> LabImages { get; set; }

        protected override void OnModelCreating(ModelBuilder builder)
        {
            base.OnModelCreating(builder);
            builder.ApplyConfigurationsFromAssembly(typeof(ApplicationDbContext).Assembly);
        }
    }

    public class PhotoItem
    {
        public Guid PhotoItemId { get; set; }
        public Guid ImageId { get; set; }
        public virtual LabImage LabImage { get; set; }
    }

    public class LabImage
    {
        public Guid ImageId { get; set; }
    }

    public class LabImageConfiguration : IEntityTypeConfiguration<LabImage>
    {
        public void Configure(EntityTypeBuilder<LabImage> builder)
        {
            builder.ToTable("Image", "lab", t => t.ExcludeFromMigrations());
            builder.HasKey(t => t.ImageId);
        }
    }

    public class PhotoItemConfiguration : IEntityTypeConfiguration<PhotoItem>
    {
        public void Configure(EntityTypeBuilder<PhotoItem> builder)
        {
            builder.HasKey(t => t.PhotoItemId);
            builder.HasOne(t => t.LabImage).WithMany().HasForeignKey(t => t.ImageId).OnDelete(DeleteBehavior.NoAction);
        }
    }

Now try to create migration. First migration will be OK. But next migrations will always generate drop and create foreign key from PhotoItem to LabImage.

Include provider and version information

EF Core version: 5.0.1
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.1
Operating system: Windows 10
IDE: Visual Studio 2019 16.8

[ajcvickers]

/cc @AndriySvyryd @bricelam

[AndriySvyryd]

@ajcvickers This is not a regression