Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelationalTypeMapper: FK facet propagation #2455

Closed
AndriySvyryd opened this issue Jun 23, 2015 · 1 comment
Closed

RelationalTypeMapper: FK facet propagation #2455

AndriySvyryd opened this issue Jun 23, 2015 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
1.1.0

Comments

@AndriySvyryd
Copy link
Member

If the user specifies a store type for a principal key column that is different from the default creating a foreign key might result in a store error due to type mismatch.
This isn't too bad for explicit FKs, as the user can easily configure the store type, but for shadow state FKs and FKs found by convention it would be harder to figure out and would require more code to fix.
RelationalTypeMapper should get the store type from the principal key if it's not set on the foreign key.
@rowanmiller rowanmiller mentioned this issue Jun 23, 2015
Closed
20 tasks
@rowanmiller rowanmiller added this to the 7.0.0 milestone Jun 26, 2015
@rowanmiller rowanmiller changed the title RelationalTypeMapper: Shadow FK facet propagation RelationalTypeMapper: FK facet propagation Sep 17, 2015
@rowanmiller rowanmiller mentioned this issue Sep 17, 2015
Closed
@rowanmiller rowanmiller mentioned this issue Jan 6, 2016
Closed
@AndriySvyryd AndriySvyryd self-assigned this Mar 8, 2016
@rowanmiller rowanmiller modified the milestones: 1.0.0, 1.0.1 May 13, 2016
@roji roji mentioned this issue May 14, 2016
Closed
@ajcvickers
Copy link
Contributor

@AndriySvyryd Poaching this.

ajcvickers added a commit that referenced this issue Jun 28, 2016
@ajcvickers
Propagate type mapping from principal property to dependent property
e51b9af 
So that if the type mapping for a primary key is changed, then the type mapping for referencing foreign keys will also change.

Issue #2455
@ajcvickers ajcvickers mentioned this issue Jun 28, 2016
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2016
@ajcvickers ajcvickers mentioned this issue Aug 3, 2016
Closed
@scottbrady91 scottbrady91 mentioned this issue Sep 1, 2016
Closed
@ajcvickers ajcvickers modified the milestones: 1.1.0-preview1, 1.1.0 Oct 15, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@ajcvickers @rowanmiller @AndriySvyryd