Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset is not preserved when saving DateTimeOffset to Cosmos #24684

Closed
ajcvickers opened this issue Apr 19, 2021 · 1 comment · Fixed by #25827
Closed

Offset is not preserved when saving DateTimeOffset to Cosmos #24684

ajcvickers opened this issue Apr 19, 2021 · 1 comment · Fixed by #25827
Labels
area-cosmos area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Contributor

Failed tests

Microsoft.EntityFrameworkCore.Cosmos.BuiltInDataTypesCosmosTest.Can_query_using_any_data_type
Assert.Equal() Failure\r\nExpected: 0001-01-01T00:00:00.0000000+00:00\r\nActual:   0001-01-01T00:00:00.0000000-08:00
   at Microsoft.EntityFrameworkCore.BuiltInDataTypesTestBase`1.QueryBuiltInDataTypesTest[TEntity](EntityEntry`1 source) in C:\dotnet\efcore\test\EFCore.Specification.Tests\BuiltInDataTypesTestBase.cs:line 475
   at Microsoft.EntityFrameworkCore.BuiltInDataTypesTestBase`1.Can_query_using_any_data_type() in C:\dotnet\efcore\test\EFCore.Specification.Tests\BuiltInDataTypesTestBase.cs:line 183

Microsoft.EntityFrameworkCore.Cosmos.BuiltInDataTypesCosmosTest.Can_query_using_any_data_type_shadow
Assert.Equal() Failure\r\nExpected: 0001-01-01T00:00:00.0000000+00:00\r\nActual:   0001-01-01T00:00:00.0000000-08:00
   at Microsoft.EntityFrameworkCore.BuiltInDataTypesTestBase`1.QueryBuiltInDataTypesTest[TEntity](EntityEntry`1 source) in C:\dotnet\efcore\test\EFCore.Specification.Tests\BuiltInDataTypesTestBase.cs:line 475
   at Microsoft.EntityFrameworkCore.BuiltInDataTypesTestBase`1.Can_query_using_any_data_type_shadow() in C:\dotnet\efcore\test\EFCore.Specification.Tests\BuiltInDataTypesTestBase.cs:line 194
@ajcvickers ajcvickers added this to the 6.0.0 milestone Apr 19, 2021
@AndriySvyryd
Copy link
Member

Consider adding a warning

AndriySvyryd added a commit that referenced this issue Sep 1, 2021
@AndriySvyryd
Cosmos: Don't map collections as owned types
09bef5a 
Reenable test for 24684

Fixes #25749
Fixes #24684
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 1, 2021
@AndriySvyryd AndriySvyryd removed their assignment Sep 1, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Sep 1, 2021
Merged
AndriySvyryd added a commit that referenced this issue Sep 1, 2021
@AndriySvyryd
Cosmos: Don't map collections as owned types
d0d501b 
Reenable test for 24684

Fixes #25749
Fixes #24684
AndriySvyryd added a commit that referenced this issue Sep 1, 2021
@AndriySvyryd
Cosmos: Don't map collections as owned types
f18729f 
Reenable test for 24684

Fixes #25749
Fixes #24684
AndriySvyryd added a commit that referenced this issue Sep 1, 2021
@AndriySvyryd
Cosmos: Don't map collections as owned types
538dab2 
Fixes #25749
Fixes #24684
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Sep 2, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos: Don't map collections as owned types dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd