Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the standard reflection API for decoding nullability information #24744

Closed
roji opened this issue Apr 23, 2021 · 1 comment · Fixed by #26967
Closed

Switch to the standard reflection API for decoding nullability information #24744

roji opened this issue Apr 23, 2021 · 1 comment · Fixed by #26967
Assignees
@roji
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Apr 23, 2021

We currently have our own code for detecting whether reference properties are nullable or not; a standard one is being developed in dotnet/runtime#29723. Switch to that when we can.
@roji roji self-assigned this Apr 23, 2021
@ajcvickers ajcvickers added this to the Backlog milestone Apr 26, 2021
@roji
Copy link
Member Author

roji commented Jul 13, 2021

This has been unblocked for 6.0.0-preview7.

@roji roji removed the blocked label Jul 13, 2021
@roji roji removed this from the Backlog milestone Jul 13, 2021
@ajcvickers ajcvickers added this to the Backlog milestone Jul 16, 2021
@roji roji mentioned this issue Jul 28, 2021
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Oct 25, 2021
roji added a commit to roji/efcore that referenced this issue Dec 11, 2021
@roji
Replace our nullability decoding with the new BCL API
2e8b019 
Closes dotnet#24744
@roji roji mentioned this issue Dec 11, 2021
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 11, 2021
roji added a commit that referenced this issue Dec 14, 2021
@roji
Replace our nullability decoding with the new BCL API (#26967)
0e1e95b 
Closes #24744
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Replace our nullability decoding with the new BCL API roji/efcore
2 participants
@ajcvickers @roji