Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure edition options annotations don't get generated as Fluent APIs #25434

Closed
roji opened this issue Aug 5, 2021 · 0 comments · Fixed by #25435
Closed

Azure edition options annotations don't get generated as Fluent APIs #25434

roji opened this issue Aug 5, 2021 · 0 comments · Fixed by #25435
Assignees
@roji
Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Aug 5, 2021

We don't scaffold these, but it's still better to have the Fluent API calls in the model snapshot, rather than raw annotations.

Will do this as part of the work on #23848
@roji roji self-assigned this Aug 5, 2021
@roji roji mentioned this issue Aug 5, 2021
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Aug 6, 2021
roji added a commit to roji/efcore that referenced this issue Aug 11, 2021
@roji
Fixes around namespaces and Fluent API calls
ad51db0 
* Add using namespace directives for scaffolded Fluent API calls which
  are outside the standard namespaces.
* Generate provider Fluent API calls as type-qualified in the model
  snapshot, to prevent ambiguity in multi-provider scenarios.

Closes dotnet#25046
Closes dotnet#23848
Closes dotnet#25434
roji added a commit that referenced this issue Aug 12, 2021
@roji
Fixes around namespaces and Fluent API calls (#25435)
65b3849 
* Add using namespace directives for scaffolded Fluent API calls which
  are outside the standard namespaces.
* Generate provider Fluent API calls as type-qualified in the model
  snapshot, to prevent ambiguity in multi-provider scenarios.

Closes #25046
Closes #23848
Closes #25434
@roji roji modified the milestones: Backlog, 6.0.0 Aug 12, 2021
@roji roji added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-next-release labels Aug 12, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 14, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fixes around namespaces and Fluent API calls dotnet/efcore
2 participants
@ajcvickers @roji