Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store value generator types/factories in the the model and remove the selector #25926

Open
Tracked by #22952
ajcvickers opened this issue Sep 8, 2021 · 2 comments
Open
Tracked by #22952

Comments

@ajcvickers
Copy link
Member

Move away from ValueGeneratorSelector, which was born out of one-model-to-rule-them-all, and instead configure the value generator type directly in the model. This shouldn't be too difficult, but it will be a breaking change, especially for providers.

@ajcvickers
Copy link
Member Author

Note: value is quite low here. But end-result would likely be less complex code.

@AndriySvyryd
Copy link
Member

Also apply WithConverter on the stored generator consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment