Long and ULong properties marked as rowversion automatically convert to binary on SQL Server #29961
Conversation
…to binary on SQL Server Fixes #12434
There was a problem hiding this comment.
Just to note that this introduces implicit usage of NumberToBytesConverter, which means it wouldn't be trimmable. I'm not claiming NumberToBytesConverter specifically is big (and we already do this kind of thing with many other converters), but in the trimming/NativeAOT world there's a tradeoff between making everything "just work" out of the box, and reducing binary size.
It may be worth shifting our mindset to requiring explicit configuration at least in some cases, especially where the explicit gesture is very simple.
|
Keep in mind that NumberToBytesConverter is already brought in anyway. |
|
@roji I think we need to consider type mapping like model building. Right now, all of type mapping, including converter selection, is referenced always, and much of it is eagerly initialized. We should get to a place where with a compiled model and queries we don't need any but pre-defined type mappings, including converters, and the rest can be trimmed. But that's not trivial. |
|
Interesting, we should think about that at some point... It definitely seems less trivial conceptually than model building, where there's a very clear (existing) split between a (runtime) model and all the (non-runtime) infra needed to build it. Maybe there's some world in which stuff like ValueGeneratorSelector is no longer there at runtime, only in AOT-generated code, I don't know. |
|
Yes, the separation is not as clear, but I think it can be done. Note we already have #25926. |
|
Sounds good - let's keep it in mind with the ongoing AOT work. |
Fixes #12434