Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't generate a migration using HiLo #26134

Closed
YeskaNova opened this issue Sep 22, 2021 · 3 comments · Fixed by #26136
Closed

Can't generate a migration using HiLo #26134

YeskaNova opened this issue Sep 22, 2021 · 3 comments · Fixed by #26136
Assignees
@roji
Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
6.0.0

Comments

@YeskaNova
Copy link

When I generate the migrations, I have this error for all the primary keys that are configured to use HiLo

image

Include provider and version information

EF Core version: 6.0.0-rtm.21471.18
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET 6.0
Operating system: Windows 10 Pro
IDE: Visual Studio 2019 16.3
@roji roji self-assigned this Sep 22, 2021
roji added a commit that referenced this issue Sep 22, 2021
@roji
Fix snapshot generation with model-level HiLo
ce2d65b 
Fixes #26134
roji added a commit that referenced this issue Sep 22, 2021
@roji
Fix snapshot generation with HiLo
60ec60b 
Fixes #26134
@roji roji mentioned this issue Sep 22, 2021
Merged
@roji
Copy link
Member

roji commented Sep 22, 2021

Thanks, I can see the bug and have submitted #26136 to fix this for 6.0.

@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 22, 2021
@YeskaNova
Copy link
Author

Thank you @roji

@roji roji reopened this Sep 22, 2021
@roji
Copy link
Member

roji commented Sep 22, 2021

As a workaround, you can replace SqlServerModelBuilderExtensions with SqlServerPropertyBuilderExtensions on all property configurations.

roji added a commit that referenced this issue Sep 22, 2021
@roji
Fix snapshot generation with HiLo (#26136)
e0dbe5a 
Fixes #26134
@ajcvickers ajcvickers added this to the 6.0.0 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[6.0] Fix snapshot generation with HiLo dotnet/efcore
3 participants
@ajcvickers @roji @YeskaNova