-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update formatting code for double-nested lambdas #26349
Labels
area-scaffolding
punted-for-7.0
Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints.
type-bug
Milestone
Comments
/cc @maumar |
ajcvickers
changed the title
Bad formatting of scaffolded temporal table configuration
Update formatting code for double-nested lambdas
Oct 16, 2021
bricelam
added a commit
to bricelam/efcore
that referenced
this issue
Jul 1, 2022
Part of dotnet#4038, part of dotnet#27588, fixes dotnet#27598, resolves dotnet#8434, resolves dotnet#21882, fixes dotnet#26349
bricelam
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Jul 1, 2022
I made some progress on this in PR #28358. The lambda is now indented. But the indentation is a little weird since we don't break multi-line arguments into properly. Here are the remaining changes I'd like to see: - entity.ToTable(tb => tb.IsTemporal(ttb =>
+ entity.ToTable(
+ tb => tb.IsTemporal(
+ ttb =>
{
ttb.UseHistoryTable(""CustomerHistory"");
ttb
.HasPeriodStart(""PeriodStart"")
.HasColumnName(""PeriodStart"");
ttb
.HasPeriodEnd(""PeriodEnd"")
.HasColumnName(""PeriodEnd"");
})); |
bricelam
added
propose-punt
and removed
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
labels
Jul 7, 2022
ajcvickers
added
punted-for-7.0
Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints.
and removed
propose-punt
labels
Jul 9, 2022
bricelam
added a commit
to bricelam/efcore
that referenced
this issue
Jul 11, 2022
Part of dotnet#4038, part of dotnet#27588, resolves dotnet#8434, resolves dotnet#21882, part of dotnet#26349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-scaffolding
punted-for-7.0
Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints.
type-bug
Currently the code doesn't handle indents correctly. For example, scaffolded temporal table configuration:
The text was updated successfully, but these errors were encountered: