Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query/Test: convert the "no_data" tests in NorthwindAggregateOperatorsQueryTestBase to use AssertQuery #26397

Closed
maumar opened this issue Oct 18, 2021 · 3 comments · Fixed by #26420
Closed

Query/Test: convert the "no_data" tests in NorthwindAggregateOperatorsQueryTestBase to use AssertQuery #26397

maumar opened this issue Oct 18, 2021 · 3 comments · Fixed by #26420
Assignees
@maumar
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
7.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Oct 18, 2021

No description provided.

@maumar maumar self-assigned this Oct 18, 2021
@maumar
Copy link
Contributor Author

maumar commented Oct 18, 2021

also Select_All

@maumar
Copy link
Contributor Author

maumar commented Oct 18, 2021

OfType_Select, OfType_Select_OfType_Select

@maumar
Copy link
Contributor Author

maumar commented Oct 18, 2021

Contains_over_entityType_should_rewrite_to_identity_equality (need to add assertquery method for contains result op)

@maumar maumar added this to the MQ milestone Oct 19, 2021
@maumar maumar changed the title Query/Test: convert the "no_data" tests in NorthwindAggregateOperatorsQueryTestBase to use AssertQueryScalar Query/Test: convert the "no_data" tests in NorthwindAggregateOperatorsQueryTestBase to use AssertQuery Oct 21, 2021
maumar added a commit that referenced this issue Oct 21, 2021
@maumar
Fix to #26397 - Query/Test: convert the "no_data" tests in NorthwindA…
95e6243 
…ggregateOperatorsQueryTestBase to use AssertQuery

We can use assert methods for individual result operators (min, max, average) as well as AssertSingleResult for ones which use complicated/correlated arguments in the final method.

Fixes #26397
@maumar maumar mentioned this issue Oct 21, 2021
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 21, 2021
maumar added a commit that referenced this issue Oct 21, 2021
@maumar
Fix to #26397 - Query/Test: convert the "no_data" tests in NorthwindA…
8bf338f 
…ggregateOperatorsQueryTestBase to use AssertQuery

We can use assert methods for individual result operators (min, max, average) as well as AssertSingleResult for ones which use complicated/correlated arguments in the final method.

Fixes #26397
maumar added a commit that referenced this issue Oct 21, 2021
@maumar
Fix to #26397 - Query/Test: convert the "no_data" tests in NorthwindA…
62df4ba 
…ggregateOperatorsQueryTestBase to use AssertQuery

We can use assert methods for individual result operators (min, max, average) as well as AssertSingleResult for ones which use complicated/correlated arguments in the final method.

Fixes #26397
@ghost ghost closed this as completed in #26420 Oct 21, 2021
ghost pushed a commit that referenced this issue Oct 21, 2021
@maumar
Fix to #26397 - Query/Test: convert the "no_data" tests in NorthwindA…
5e27aaa 
…ggregateOperatorsQueryTestBase to use AssertQuery (#26420)

We can use assert methods for individual result operators (min, max, average) as well as AssertSingleResult for ones which use complicated/correlated arguments in the final method.

Fixes #26397
@maumar maumar modified the milestones: MQ, 7.0.0 Oct 21, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
7.0.0
2 participants
@ajcvickers @maumar