Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MigrationsSqliteTest xxx_sequence not calling the correct base class #26571

Closed
bobbyangers opened this issue Nov 8, 2021 · 0 comments · Fixed by #26572
Closed

MigrationsSqliteTest xxx_sequence not calling the correct base class #26571

bobbyangers opened this issue Nov 8, 2021 · 0 comments · Fixed by #26572
Assignees
@roji
Labels
area-sqlite area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-bug
Milestone
7.0.0

Comments

@bobbyangers
Copy link
Contributor

bobbyangers commented Nov 8, 2021 •
edited
Loading

It seems that these tests are not calling the correct base method.

MigrationsSqliteTest.cs L923-939

        public override Task Create_sequence()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);

        public override Task Create_sequence_all_settings()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);

        public override Task Alter_sequence_all_settings()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);

        public override Task Alter_sequence_increment_by()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);

        public override Task Drop_sequence()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);

        public override Task Rename_sequence()
            => AssertNotSupportedAsync(base.Create_sequence, SqliteStrings.SequencesNotSupported);
bobbyangers added a commit to bobbyangers/efcore that referenced this issue Nov 8, 2021
@bobbyangers
Summary of the changes
eceb2e0 
Correct tests to call correct base class method
- Create_sequence
- Create_sequence_all_settings
- Alter_sequence_all_settings
- Alter_sequence_increment_by
- Drop_sequence
- Rename_sequence
- Move_sequence

Fixes dotnet#26571
@bobbyangers bobbyangers mentioned this issue Nov 8, 2021
Merged
6 tasks
bobbyangers added a commit to bobbyangers/efcore that referenced this issue Nov 8, 2021
@bobbyangers
Summary of the changes
8c8237c 
Correct tests to call correct base class method
- Create_sequence
- Create_sequence_all_settings
- Alter_sequence_all_settings
- Alter_sequence_increment_by
- Drop_sequence
- Rename_sequence
- Move_sequence

Fixes dotnet#26571
@roji roji self-assigned this Nov 8, 2021
@roji roji added this to the 7.0.0 milestone Nov 8, 2021
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 8, 2021
roji pushed a commit that referenced this issue Nov 8, 2021
@bobbyangers
Fix MigrationsSqliteTest tests (#26572)
c5aa799 
Correct tests to call correct base class method

Fixes #26571
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-sqlite area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix MigrationsSqliteTest tests bobbyangers/efcore
3 participants
@ajcvickers @bobbyangers @roji