Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overload EnableRetryOnFailure that allows specifying errorCodesToAdd without count / delay #27074

Closed
midgleyc opened this issue Dec 29, 2021 · 0 comments · Fixed by #27135
Closed

Add overload EnableRetryOnFailure that allows specifying errorCodesToAdd without count / delay #27074

midgleyc opened this issue Dec 29, 2021 · 0 comments · Fixed by #27135
Labels
area-query area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
7.0.0

Comments

@midgleyc
Copy link

I'd like a way to call SqlServerDbContextOptionsBuilder.EnableRetryOnFailure with errorCodesToAdd without forcing maxRetryCount and maxRetryDelay to be added.

I want to keep the latter two default, so I copied the values from ExecutionStrategy as they're protected and so not visible externally, but it would be nicer if I didn't have to do this and could just specify the errorCodesToAdd property I'm interested in.

Initially reported at npgsql/efcore.pg#2048. There is some discussion there.
@midgleyc midgleyc mentioned this issue Dec 29, 2021
Closed
@ajcvickers ajcvickers added area-query area-save-changes good first issue This issue should be relatively straightforward to fix. labels Jan 6, 2022
@ajcvickers ajcvickers added this to the Backlog milestone Jan 6, 2022
@Marusyk Marusyk mentioned this issue Jan 7, 2022
Merged
AndriySvyryd pushed a commit that referenced this issue Jan 21, 2022
@Marusyk
Add overload to SqlServerDbContextOptionsBuilder.EnableRetryOnFailure…
a482bd1 
… with errorNumbersToAdd without forcing maxRetryCount and maxRetryDelay

Fixes #27074
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 21, 2022
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 7.0.0 Jan 21, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers mentioned this issue Mar 1, 2022
Closed
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
7.0.0
3 participants
@ajcvickers @AndriySvyryd @midgleyc