Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Convert query tests to conditional theory #27229

Closed
smitpatel opened this issue Jan 20, 2022 · 1 comment · Fixed by #27274
Closed

Test: Convert query tests to conditional theory #27229

smitpatel opened this issue Jan 20, 2022 · 1 comment · Fixed by #27274
Assignees
@maumar
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@smitpatel
Copy link
Contributor

efcore/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindSelectQueryCosmosTest.cs

Lines 319 to 330 in e42407c

public override void Select_nested_collection_multi_level()
{
// Cosmos client evaluation. Issue #17246.
AssertTranslationFailed(
() =>
{
base.Select_nested_collection_multi_level();
return Task.CompletedTask;
});
AssertSql();
}

Test is of type void. Method used inside is AssertTranslationFailed is async and not awaited. There are several tests like that in the same file. Could be more.
@maumar maumar self-assigned this Jan 20, 2022
@maumar
Copy link
Contributor

maumar commented Jan 20, 2022

was on my list to fix when I saw Arthur's pr.

@ajcvickers ajcvickers added this to the 7.0.0 milestone Jan 22, 2022
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
426e93b 
Converting Northwind query tests to query infra.

Fixes #27229
@maumar maumar mentioned this issue Jan 25, 2022
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 25, 2022
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
f26acda 
Converting Northwind query tests to query infra.

Fixes #27229
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
eeafc7b 
Converting Northwind query tests to query infra.

Fixes #27229
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
8145bde 
Converting Northwind query tests to query infra.

Fixes #27229
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
ef0e433 
Converting Northwind query tests to query infra.

Fixes #27229
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
daa232f 
Converting Northwind query tests to query infra.

Fixes #27229
maumar added a commit that referenced this issue Jan 25, 2022
@maumar
Fix to #27229 - Test: Convert query tests to conditional theory
ce6a2c6 
Converting Northwind query tests to query infra.

Fixes #27229
@maumar maumar closed this as completed in 7afa38a Jan 26, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1, 7.0.0-preview2 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix to #27229 - Test: Convert query tests to conditional theory dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar