Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.Diagnostics.DiagnosticSource and System.Collections.Immutable for reference and runtime pack version. #27715

Closed
AraHaan opened this issue Mar 27, 2022 · 2 comments · Fixed by #27720
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-cleanup
Milestone

Comments

@AraHaan
Copy link
Member

AraHaan commented Mar 27, 2022

The discussion was started in #27673, however it was not completed on if I should open a pull request with my already made changes to remove these dependencies as they can be replaced with the runtime and ref pack versions of them for .NET 6+ when using efcore which can help clean up the dependencies list (as well as prevent possible version downgrades for them).

Also another thing I think is also the case for S.D.DS and S.C.I:

  • the API shape seems to not change much for a while now on the assemblies (that I know of so far)
  • the API on these assemblies seems to be completely (or almost if not completely) stable
  • other things I cannot think of at the moment.

As such I think the best route for these is to utilize the built in copies on the default Microsoft.NETCore.App framework packs over the package reference for this reason, if new functionality is required (if new apis are added to them), then require them to update their runtime and ref packs.

@AraHaan
Copy link
Member Author

AraHaan commented Mar 28, 2022

Can we also try unpinning to preview.2 to pin to preview.4? Since the Unsafe package should not be referenced anywhere?

AraHaan added a commit to AraHaan/efcore that referenced this issue Mar 28, 2022
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>

Fixes dotnet#27715.
@ajcvickers ajcvickers added this to the 7.0.0 milestone Apr 4, 2022
@ajcvickers
Copy link
Member

@AraHaan Thanks; we have merged the PR.

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 18, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview4 Apr 18, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview4, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants